Skip to content

Conversation

@ltzmaxwell
Copy link
Contributor

@ltzmaxwell ltzmaxwell commented Jan 26, 2026

this solution is much more simpler than #4958 , no need to inject redefine variable, no change to the ForStmt executionlogic.

@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jan 26, 2026
@ltzmaxwell ltzmaxwell changed the title fix(gnovm): loopvar shadow, capture, alternative to #4958 WIP fix(gnovm): loopvar shadow, capture, alternative to #4958 Jan 26, 2026
@ltzmaxwell ltzmaxwell marked this pull request as draft January 26, 2026 07:59
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 26, 2026

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 87.93970% with 48 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/preprocess.go 90.25% 16 Missing and 14 partials ⚠️
gnovm/pkg/gnolang/nodes.go 66.66% 9 Missing and 5 partials ⚠️
gnovm/pkg/gnolang/helpers.go 89.47% 1 Missing and 1 partial ⚠️
gnovm/pkg/gnolang/nodes_string.go 77.77% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants