fix(boards2): change default permissions to enforce single user roles#5113
Open
jeronimoalbi wants to merge 9 commits intognolang:masterfrom
Open
fix(boards2): change default permissions to enforce single user roles#5113jeronimoalbi wants to merge 9 commits intognolang:masterfrom
jeronimoalbi wants to merge 9 commits intognolang:masterfrom
Conversation
By default permissions allows multiple roles per user. This changeset adds an option to configure permissions to only allow a single role per user. Boards2 uses this options because within boards there are a fixed set of roles which are mutually exclusive. Custom permissions implementation could define custom roles on top of the ones pre-defined by Boards2, but these roles are only relevant within the custom implementation and not within Boards2.
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The permissions implementation allows multiple roles per user because custom implementations might need to have more roles within their boards, which might make sense to the realm that implements the permissions.
Boards2 in the other hand defines a fixed set of mutually exclusive roles,
owner,admin,moderatorandguest, so it must ensure users don't have more than one role.Without this change it would be possible to assign, for example, the roles
ownerandadminto the same user, which is fine but semantically doesn't make sense.