chore: update multisig docs: default sorting, derivation guidance and examples#5117
chore: update multisig docs: default sorting, derivation guidance and examples#5117D4ryl00 wants to merge 4 commits intognolang:masterfrom
Conversation
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
docs/users/interact-with-gnokey.md
Outdated
| `gnokey add multisig` sorts member pubkeys by default (`-nosort=false`), so the | ||
| creation order does **not** matter. The multisig has a deterministic member order | ||
| based on pubkey sorting, not on the CLI order you provided. |
There was a problem hiding this comment.
Nit: Consider consolidating the "order does not matter" reference into a single location and referencing it instead with something like as mentioned above, order is handled automatically. The issue is that having same/similar explanations in multiple places will make it harder to maintain.
There was a problem hiding this comment.
You're right, I simplified. Let me know if it's not enough.
done in b9fb511
| up with the same multisig public key/address, and signing will fail. | ||
|
|
||
| If you set `-nosort=true`, then ordering matters and everyone must use the same | ||
| explicit order. |
There was a problem hiding this comment.
nit: When set, go flags are implicitly true, so -nosort=true is redundant.
| explicit order. | |
| If you set `-nosort`, then ordering matters and everyone must use the same | |
| explicit order. |
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
712dc2b to
b9fb511
Compare
depends on #5122