Open
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5109
This PR include 2 fixes:
Issue 1
When integration tests spawn subprocess nodes, the configuration is serialized to JSON and passed via stdin. The
WALDisabledfield in the consensus configuration has ajson:"-"tag, which means it is excluded from JSON serialization. This exclusion causesWALDisabledto default to false, resulting in WAL files being created even though the parent process intended to disable them. This issue arose when running a test multiple times (-count=X) and when restarting the node, as the genesis was changing but not the WAL file.-> I now force-set
WALDisabledto false, as it is unnecessary for integration tests. I also prevent WAL catch-up when WAL is disabled.issue 2
When restarting the node during testing, it will not produce blocks (
CreateEmptyBlocks = false- the test default for determinism) until it receives transactions. However, the tests wait forReady()(which is waiting for a block to appear) before sending transactions, resulting in a deadlock.-> Simply mark the node as ready when if any block is present when starting the node