-
-
Notifications
You must be signed in to change notification settings - Fork 292
Feature: Plot Display #4796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Feature: Plot Display #4796
Conversation
3 Detekt FailuresRules flagged (3):
|
1 Detekt Failure
|
| when (status) { | ||
| GardenPlotApi.PlotStatusType.PESTS -> createPestIcon(plot) | ||
| GardenPlotApi.PlotStatusType.SPRAYS -> plot.currentSpray?.type?.toInternalName()?.getItemStack()?.createCleanItem() | ||
| GardenPlotApi.PlotStatusType.LOCKED -> ItemStack(Blocks.wooden_button).createCleanItem() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would have to make a function somewhere that returns wooden_button on 1.8 and OAK_BUTTON on 1.21
| } | ||
| } | ||
|
|
||
| fun Renderable.Companion.fakeInventory( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you test if this works on 1.21? because the only other usage of renderable inventory doesnt render the texture on 1.21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it doesnt work on 1.21 I just checked
oops
any idea why it doesnt render?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure, i havent ever looked into why the personal compactor doesnt render
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Dependencies
What
Adds a display for the garden plots.
Also cleaned up a bit of the logic in the backend.
Images
Changelog New Features