Skip to content

Conversation

@ILike2WatchMemes
Copy link
Contributor

@ILike2WatchMemes ILike2WatchMemes commented Oct 19, 2025

Dependencies

What

Adds a display for the garden plots.
Also cleaned up a bit of the logic in the backend.

Images grafik

Changelog New Features

  • Added Plot Display. - ILike2WatchMemes
    • Displays the current state of your plots in a display.

@github-actions github-actions bot added Fails Multi-Version A pr that fails build multiversion and removed Fails Multi-Version A pr that fails build multiversion labels Oct 20, 2025
@github-actions github-actions bot added the Detekt Has detekt problem label Oct 20, 2025
@github-actions
Copy link

3 Detekt Failures

Rules flagged (3): RepoPatternRegexTestMissing, UseOrEmpty, VarCouldBeVal
Files flagged (2): PestApi.kt, GardenPlotDisplay.kt

@github-actions github-actions bot added the Fails Multi-Version A pr that fails build multiversion label Oct 20, 2025
@github-actions
Copy link

1 Detekt Failure

@hannibal002 hannibal002 added this to the 6.0.0 milestone Oct 30, 2025
when (status) {
GardenPlotApi.PlotStatusType.PESTS -> createPestIcon(plot)
GardenPlotApi.PlotStatusType.SPRAYS -> plot.currentSpray?.type?.toInternalName()?.getItemStack()?.createCleanItem()
GardenPlotApi.PlotStatusType.LOCKED -> ItemStack(Blocks.wooden_button).createCleanItem()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would have to make a function somewhere that returns wooden_button on 1.8 and OAK_BUTTON on 1.21

}
}

fun Renderable.Companion.fakeInventory(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test if this works on 1.21? because the only other usage of renderable inventory doesnt render the texture on 1.21

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it doesnt work on 1.21 I just checked
oops

any idea why it doesnt render?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure, i havent ever looked into why the personal compactor doesnt render

@NopoTheGamer NopoTheGamer removed this from the 6.0.0 milestone Dec 17, 2025
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 17, 2025
@github-actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Detekt Has detekt problem Fails Multi-Version A pr that fails build multiversion Merge Conflicts There are open merge conflicts with the beta branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants