Skip to content

ContainerRegistry Service: Upgrade API version from 2025-04-01 to 2025-11-01#31515

Merged
sreallymatt merged 6 commits intohashicorp:mainfrom
magodo:acr_api_upgrade
Feb 3, 2026
Merged

ContainerRegistry Service: Upgrade API version from 2025-04-01 to 2025-11-01#31515
sreallymatt merged 6 commits intohashicorp:mainfrom
magodo:acr_api_upgrade

Conversation

@magodo
Copy link
Collaborator

@magodo magodo commented Jan 16, 2026

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Upgrade API version from 2025-04-01 to 2025-11-01 for ACR.

Additionally, this PR fixes two test cases failing in the main:

=== RUN   TestAccContainerRegistry_networkAccessProfileUpdate
=== PAUSE TestAccContainerRegistry_networkAccessProfileUpdate
=== CONT  TestAccContainerRegistry_networkAccessProfileUpdate
    testcase.go:173: Step 4/6 error: Pre-apply plan check(s) failed:
        'azurerm_container_registry.test' - expected action to not be Replace, path: [[name] [resource_group_name]] tried to update a value that is ForceNew
--- FAIL: TestAccContainerRegistry_networkAccessProfileUpdate (131.26s)
FAIL
=== RUN   TestAccContainerRegistry_networkAccessProfileIp
=== PAUSE TestAccContainerRegistry_networkAccessProfileIp
=== CONT  TestAccContainerRegistry_networkAccessProfileIp
    testcase.go:173: Step 7/9 error: Error running apply: exit status 1
        Error: applying sku "Basic" for Registry (Subscription: "*******"
        Resource Group Name: "acctestRG-260115001446164517"
        Registry Name: "testAccCr260115001446164517"): updating Registry (Subscription: "*******"
        Resource Group Name: "acctestRG-260115001446164517"
        Registry Name: "testAccCr260115001446164517"): performing Update: unexpected status 409 (409 Conflict) with error: Conflict: Cannot update the registry SKU due to reason: Registry has IP rules. Please remove them before proceeding. For more information, please visit https://aka.ms/acr/vnet.. For more information on SKU tiers, please visit https://aka.ms/acr/tiers
          with azurerm_container_registry.test,
          on terraform_plugin_test.tf line 40, in resource "azurerm_container_registry" "test":
          40: resource "azurerm_container_registry" "test" {
--- FAIL: TestAccContainerRegistry_networkAccessProfileIp (173.64s)
FAIL

The fixes for these test cases are just changing the test case configs, which were obviously wrong. Hence should be safe to also include here.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - I've left some comments inline

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM ✅

@sreallymatt sreallymatt merged commit 0c787b7 into hashicorp:main Feb 3, 2026
35 checks passed
@github-actions github-actions bot added this to the v4.59.0 milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants