Skip to content

refactor(types): move @types/* dependencies into individual workspaces #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yusukebe merged 3 commits into from
Jan 22, 2026
Merged

refactor(types): move @types/* dependencies into individual workspaces #1688

yusukebe merged 3 commits into from
Jan 22, 2026

Conversation

@BarryThePenguin
Copy link
Contributor

@BarryThePenguin BarryThePenguin commented Jan 7, 2026

Moving @types/* dependencies around and cleaning up some type assertions

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: ceb8414

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

BarryThePenguin
BarryThePenguin commented Jan 7, 2026
View reviewed changes
package.json
Comment on lines -45 to -47
"@types/bun": "^1.0.0",
"@types/node": "^25.0.3",
"@types/ws": "^8.18.0",
Copy link
Contributor Author

@BarryThePenguin BarryThePenguin Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why exactly.. but in #1077 and #1098 I moved these packages to the monorepo root.

I think it may have been related to tsup config needing to resolve types relative to the root? But we don't have that problem anymore..

@codecov
Copy link

codecov bot commented Jan 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.69%. Comparing base (fbec266) to head (ceb8414).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   92.11%   92.69%   +0.57%     
==========================================
  Files         111      112       +1     
  Lines        3678     3737      +59     
  Branches      960      946      -14     
==========================================
+ Hits         3388     3464      +76     
+ Misses        255      245      -10     
+ Partials       35       28       -7
Flag Coverage Δ
bun-compress 78.94% <100.00%> (+60.02%) ⬆️
bun-transpiler 97.43% <ø> (?)
casbin 86.48% <ø> (ø)
cloudflare-access 100.00% <ø> (ø)
graphql-server 92.15% <ø> (ø)
node-ws 80.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BarryThePenguin
BarryThePenguin commented Jan 7, 2026
View reviewed changes
packages/bun-compress/src/index.test.ts

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const decompressedResponse = new Response(decompressedReadableStream as any)
const decompressedResponse = new Response(decompressedReadableStream)
Copy link
Contributor Author

@BarryThePenguin BarryThePenguin Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more type assertion ✨

@BarryThePenguin BarryThePenguin force-pushed the refactor/type-definitions branch 2 times, most recently from cc4289f to 69dcb46 Compare January 7, 2026 10:53
yusukebe
yusukebe reviewed Jan 11, 2026
View reviewed changes
.github/actions/what-changed/main.ts Outdated
import * as exec from '@actions/exec'

const exclude = new Set(['@hono/bun-transpiler'])
const exclude = new Set(['@hono/bun-compiler', '@hono/bun-transpiler'])
Copy link
Member

@yusukebe yusukebe Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the @hono/bun-compiler is a typo?

Copy link
Member

@yusukebe yusukebe Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BarryThePenguin !

Can you look at this?

Copy link
Contributor Author

@BarryThePenguin BarryThePenguin Jan 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Forgot about this.. There are a couple of things here..

  • @hono/bun-compiler is a typo, yes. This should be @hono/bun-compress
  • Bun v1.3.3 introduced CompressionStream and DecompressionStream, so the tests for @hono/bun-compress aren't actually testing the code.
  • It looks like @hono/bun-compress gets quite a few downloads, so it's probably worth keeping around

So I think it's probably worth the effort of testing the package on the older version of bun

Copy link
Member

@yusukebe yusukebe Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BarryThePenguin

Got them! So, can you update this branch?

Copy link
Contributor Author

@BarryThePenguin BarryThePenguin Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that's sorted now 👀

@BarryThePenguin BarryThePenguin force-pushed the refactor/type-definitions branch 3 times, most recently from 2af149d to e6abe6e Compare January 22, 2026 08:54
@BarryThePenguin BarryThePenguin force-pushed the refactor/type-definitions branch from e6abe6e to ceb8414 Compare January 22, 2026 20:22
yusukebe
yusukebe approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jan 22, 2026

@BarryThePenguin

Thank you! Let's go!

@yusukebe yusukebe merged commit 2713f55 into honojs:main Jan 22, 2026
98 checks passed
@BarryThePenguin BarryThePenguin deleted the refactor/type-definitions branch January 23, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yusukebe yusukebe yusukebe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BarryThePenguin @yusukebe