Allows messages with empty "aps" property. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Furthermore, the MDM documentation (page 20) explains that "There should not be an aps key. (The aps key is used only for third-party app push notifications.)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with MDM service and ApnsPHP, I notice that mdmd daemon on the supervised device is not happy with empty "aps" property.
BTW, the APNS documentation says that the "aps" is reserved but not mandatory: in fact, MDM service doesn't need it at all. And omitting the empty dictionary can save few bytes which can become big when you manage thousands of devices.
So I propose this patch to allow messages with no "aps" property.
Regards.