refactor(api): align Model API naming with Pipeline convention #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinglin
deleted the
pinglin/refactor-api-align-model-naming-with-pipeline
branch
pinglin
added a commit
that referenced
this pull request
Jan 23, 2026
**Because** - The Model API naming was inconsistent with Pipeline API conventions - Pipeline uses `TriggerPipeline` for default/latest and `TriggerPipelineRelease` for specific versions - Model was using inverted naming (`TriggerLatestModel` for latest, `TriggerModel` for specific) - The redundant "Namespace" prefix in API names was removed in protobufs to align with standard AIP conventions **This commit** - Adopts the renamed protobuf APIs from `protobufs` repo refactoring - Updates all handler functions to use new naming: - `TriggerModel` → `TriggerModelVersion` (specific version) - `TriggerLatestModel` → `TriggerModel` (default/latest) - `TriggerAsyncModel` → `TriggerAsyncModelVersion` - `TriggerAsyncLatestModel` → `TriggerAsyncModel` - `WatchModel` → `WatchModelVersion` - `WatchLatestModel` → `WatchModel` - `GetLatestModelOperation` → `GetModelOperation` - `GetModelOperation` (by ID) → `GetOperation` - Updates service layer interfaces and implementations - Updates repository interfaces (`ListNamespaceModels` → `ListModels`, `ListPublicModels` for global) - Updates worker workflows (`TriggerModelWorkflow` → `TriggerModelVersionWorkflow`) - Regenerates mock files to reflect interface changes - Updates integration test proto files
pinglin
added a commit
that referenced
this pull request
Jan 25, 2026
**Because** - The Model API naming was inconsistent with Pipeline API conventions - Pipeline uses `TriggerPipeline` for default/latest and `TriggerPipelineRelease` for specific versions - Model was using inverted naming (`TriggerLatestModel` for latest, `TriggerModel` for specific) - The redundant "Namespace" prefix in API names was removed in protobufs to align with standard AIP conventions **This commit** - Adopts the renamed protobuf APIs from `protobufs` repo refactoring - Updates all handler functions to use new naming: - `TriggerModel` → `TriggerModelVersion` (specific version) - `TriggerLatestModel` → `TriggerModel` (default/latest) - `TriggerAsyncModel` → `TriggerAsyncModelVersion` - `TriggerAsyncLatestModel` → `TriggerAsyncModel` - `WatchModel` → `WatchModelVersion` - `WatchLatestModel` → `WatchModel` - `GetLatestModelOperation` → `GetModelOperation` - `GetModelOperation` (by ID) → `GetOperation` - Updates service layer interfaces and implementations - Updates repository interfaces (`ListNamespaceModels` → `ListModels`, `ListPublicModels` for global) - Updates worker workflows (`TriggerModelWorkflow` → `TriggerModelVersionWorkflow`) - Regenerates mock files to reflect interface changes - Updates integration test proto files
pinglin
added a commit
that referenced
this pull request
Jan 25, 2026
**Because** - The Model API naming was inconsistent with Pipeline API conventions - Pipeline uses `TriggerPipeline` for default/latest and `TriggerPipelineRelease` for specific versions - Model was using inverted naming (`TriggerLatestModel` for latest, `TriggerModel` for specific) - The redundant "Namespace" prefix in API names was removed in protobufs to align with standard AIP conventions **This commit** - Adopts the renamed protobuf APIs from `protobufs` repo refactoring - Updates all handler functions to use new naming: - `TriggerModel` → `TriggerModelVersion` (specific version) - `TriggerLatestModel` → `TriggerModel` (default/latest) - `TriggerAsyncModel` → `TriggerAsyncModelVersion` - `TriggerAsyncLatestModel` → `TriggerAsyncModel` - `WatchModel` → `WatchModelVersion` - `WatchLatestModel` → `WatchModel` - `GetLatestModelOperation` → `GetModelOperation` - `GetModelOperation` (by ID) → `GetOperation` - Updates service layer interfaces and implementations - Updates repository interfaces (`ListNamespaceModels` → `ListModels`, `ListPublicModels` for global) - Updates worker workflows (`TriggerModelWorkflow` → `TriggerModelVersionWorkflow`) - Regenerates mock files to reflect interface changes - Updates integration test proto files
pinglin
added a commit
to instill-ai/instill-core
that referenced
this pull request
Jan 25, 2026
Because - The version of the model-backend service is not updated in the instill-core repository. This commit - updates the `MODEL_BACKEND_VERSION` in the `.env` file to `ee05fdd`. - updates the `modelBackend.image.tag` in the helm chart values.yaml file to `ee05fdd`. ## Changes in model-backend - refactor(api): align Model API naming with Pipeline convention (instill-ai/model-backend#785) - refactor(acl): migrate to shared ACL client library and remove deprecated handlers (instill-ai/model-backend#784) - chore(deps): bump golang.org/x/crypto from 0.39.0 to 0.45.0 (instill-ai/model-backend#781) - chore(go): upgrade to 1.25.6 - refactor(model): adopt flattened protobuf packages and AIP-compliant resource names (instill-ai/model-backend#783) Co-authored-by: pinglin <[email protected]>
pinglin
added a commit
that referenced
this pull request
Jan 26, 2026
**Because** - The Model API naming was inconsistent with Pipeline API conventions - Pipeline uses `TriggerPipeline` for default/latest and `TriggerPipelineRelease` for specific versions - Model was using inverted naming (`TriggerLatestModel` for latest, `TriggerModel` for specific) - The redundant "Namespace" prefix in API names was removed in protobufs to align with standard AIP conventions **This commit** - Adopts the renamed protobuf APIs from `protobufs` repo refactoring - Updates all handler functions to use new naming: - `TriggerModel` → `TriggerModelVersion` (specific version) - `TriggerLatestModel` → `TriggerModel` (default/latest) - `TriggerAsyncModel` → `TriggerAsyncModelVersion` - `TriggerAsyncLatestModel` → `TriggerAsyncModel` - `WatchModel` → `WatchModelVersion` - `WatchLatestModel` → `WatchModel` - `GetLatestModelOperation` → `GetModelOperation` - `GetModelOperation` (by ID) → `GetOperation` - Updates service layer interfaces and implementations - Updates repository interfaces (`ListNamespaceModels` → `ListModels`, `ListPublicModels` for global) - Updates worker workflows (`TriggerModelWorkflow` → `TriggerModelVersionWorkflow`) - Regenerates mock files to reflect interface changes - Updates integration test proto files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
TriggerPipelinefor default/latest andTriggerPipelineReleasefor specific versionsTriggerLatestModelfor latest,TriggerModelfor specific)This commit
protobufsrepo refactoringTriggerModel→TriggerModelVersion(specific version)TriggerLatestModel→TriggerModel(default/latest)TriggerAsyncModel→TriggerAsyncModelVersionTriggerAsyncLatestModel→TriggerAsyncModelWatchModel→WatchModelVersionWatchLatestModel→WatchModelGetLatestModelOperation→GetModelOperationGetModelOperation(by ID) →GetOperationListNamespaceModels→ListModels,ListPublicModelsfor global)TriggerModelWorkflow→TriggerModelVersionWorkflow)