-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add macOS support and update iOS simulator recipes (v5.1.0) #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Update simulator recipes: ip15/ip16 → ip18/ip26 (iOS 18.6, 26.1) - Update iPad recipes: ipad15/ipad16 → ipad18/ipad26 - Remove obsolete recipes: retina, sim-64bit, tall, force-copy, force-copy-all, sim-focus, avd-skin These changes modernize the default recipes for Titanium SDK 13 and Xcode 26.1.1 compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
📝 WalkthroughWalkthroughAdds mac and catalyst top-level keys and replaces legacy iOS simulator keys in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update recipe table to reflect changes in tn.json: - ip17/ip18 → ip18/ip26 (iOS 18.6, 26.1) - ipad17/ipad18 → ipad18/ipad26 - Remove obsolete recipes from documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🔇 Additional comments (1)
README.md (1)
1-127: Removed recipes have been successfully eliminated across all files.Verification confirms that all seven recipes (
avd-skin,force-copy,force-copy-all,retina,sim-64bit,sim-focus,tall) are completely absent from documentation and configuration files. The matches for "tall" are false positives appearing only within words like "install" and "globally," not as standalone recipe references.
Adds built-in recipes for building iOS apps on macOS using Mac Catalyst: - `tn mac` - Build for macOS (expands to --platform ios --target macos) - `tn catalyst` - Alias for mac recipe This feature requires Titanium SDK 13.1.0+ with macOS build support. Works on Apple Silicon Macs running macOS apps via Catalyst. Bumps version to 5.1.0 (minor release - new feature, backward compatible). Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @CHANGELOG.md:
- Line 13: Replace the incorrect lowercase "macos" with the proper "macOS" in
the changelog entry: update the description that currently reads "`mac`: Build
for macOS (`--platform ios --target macos`)" so the OS name and the target flag
use "macOS" (i.e., change `--target macos` to `--target macOS` and ensure the
descriptive text says "macOS").
In @README.md:
- Line 95: Update the README table entry that currently shows "--platform ios
--target macos" to use the correct Apple capitalization "macOS" (i.e., change
"macos" to "macOS") so the row reads "--platform ios --target macOS"; this fixes
the capitalization issue in the README.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.mdREADME.mdpackage.jsontn.json
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~95-~95: The operating system from Apple is written “macOS”.
Context: ... | --platform ios --target macos | | catalyst ...
(MAC_OS)
CHANGELOG.md
[uncategorized] ~13-~13: The operating system from Apple is written “macOS”.
Context: ...ac Catalyst - mac: Build for macOS (--platform ios --target macos) - catalyst: Alias for --mac -...
(MAC_OS)
🔇 Additional comments (6)
package.json (1)
14-14: LGTM! Version bump aligns with new features.The minor version bump to 5.1.0 appropriately reflects the addition of macOS/Catalyst support and updated simulator configurations.
CHANGELOG.md (1)
12-16: Documentation clearly describes the new macOS/Catalyst feature.The changelog entry provides clear context about the new recipes, requirements, and platform support.
README.md (2)
95-96: macOS/Catalyst recipes look correct.The new
macandcatalystrecipes properly expand to the correct Titanium CLI arguments for building macOS apps via Mac Catalyst.
112-115: The specified iOS versions in the recipe are valid. As of January 2026, iOS 26.2 is the current stable release (released December 12, 2025), which means iOS 26.1 is a legitimate intermediate version. The recipe specifications forip26andipad26with--sim-version 26.1are accurate.Likely an incorrect or invalid review comment.
tn.json (2)
11-12: macOS/Catalyst recipes are correct.The
macrecipe properly expands to build for macOS target, andcatalystcorrectly aliases to themacrecipe. The lowercase"macos"value is the correct format as documented in the README and CHANGELOG.
31-34: iOS 26 is incompatible with Xcode 16; reconsider the version target.Lines 32 and 34 specify
"26.1"as the simulator version forip26andipad26recipes. While iOS 26 does exist (as of January 2026), Xcode 16 does not include the iOS 26 SDK and cannot build for iOS 26—a newer Xcode version is required.If users with Xcode 16 run these recipes, simulator builds will fail:
tn ip26tn ipad26Either specify an iOS version that Xcode 16 supports (iOS 15–18), or document that a newer Xcode is required.
Likely an incorrect or invalid review comment.
Summary
This PR prepares TiNy v5.1.0 with two key updates:
1. macOS/Catalyst Build Support (NEW) 🎉
Added built-in recipes for building iOS apps on macOS using Mac Catalyst:
tn mac- Build for macOS (expands toti build --platform ios --target macos)tn catalyst- Alias formacrecipeRequirements:
Testing:
Both expand correctly to
ti build --platform ios --target macosand successfully build/launch macOS apps via Catalyst.2. iOS Simulator Recipe Updates
ip15/ip16→ip18/ip26(iOS 18.6, 26.1)ipad15/ipad16→ipad18/ipad26retina- all iOS screens are retina nowsim-64bit- iOS dropped 32-bit support since iOS 11tall- iPhone 5 "tall screen" referenceforce-copy,force-copy-all- legacy workaroundssim-focus,avd-skin- rarely used legacy optionsChanges
macandcatalystrecipes totn.jsonVersion Bump
This is a minor version bump (5.0.0 → 5.1.0) as it adds new functionality (macOS support) while maintaining backward compatibility.
Test plan
tn listto verify updated recipes appear correctlytn ip18andtn ip26with Xcode 26.1.1 simulatorstn macandtn catalystbuild for macOS via CatalystRelated
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.