Skip to content

884 - Adding common labels #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
psimms-r7 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

884 - Adding common labels #885

psimms-r7 wants to merge 3 commits into from

Conversation

@psimms-r7
Copy link

@psimms-r7 psimms-r7 commented Jun 19, 2023 •
edited
Loading

What does this PR do?

  • Adding a common labels helper and replacing labels with this helper
  • Adding additional labels app.kubernetes.io/part-of and app.kubernetes.io/version
  • Bump chart version

Deployed out to eks cluster and confirmed labels

#884

  • Fixes #

If you modified files in the ./charts/jenkins/ directory, please also include the following:

### Submitter checklist
- [x] I bumped the "version" key in `./charts/jenkins/Chart.yml`.
- [x] I added a new changelog entry to `./charts/jenkins/CHANGELOG.md`.
- [x] I followed the [technical requirements](https://github.com/jenkinsci/helm-charts/blob/main/CONTRIBUTING.md#technical-requirements).

Special notes for your reviewer

@psimms-r7 psimms-r7 requested a review from a team as a code owner June 19, 2023 17:25
@psimms-r7
Copy link
Author

psimms-r7 commented Jun 19, 2023

Need to look at unit tests

@psimms-r7 psimms-r7 mentioned this pull request Jun 20, 2023
Open
@psimms-r7
Copy link
Author

psimms-r7 commented Jun 20, 2023

Not 100% on how to fix the last 2 unit test issues
Tests
jcasc-config-test.yaml
secret-claims-test.yaml

kvanzuijlen
kvanzuijlen reviewed Feb 1, 2024
View reviewed changes
charts/jenkins/templates/_helpers.tpl
app.kubernetes.io/part-of: {{ .Chart.Name }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/version: {{ include "controller.tag" . }}
{{- end -}}
Copy link
Contributor

@kvanzuijlen kvanzuijlen Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also be able to define custom common labels via values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kvanzuijlen kvanzuijlen kvanzuijlen left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psimms-r7 @kvanzuijlen