Conversation
joshuay03
commented
Mar 31, 2025
|
|
||
| bool operator==(const Frame& lhs, const Frame& rhs) noexcept { | ||
| return lhs.frame == rhs.frame && lhs.line == rhs.line; | ||
| return lhs.frame == rhs.frame && lhs.file == rhs.file && lhs.line == rhs.line; |
Collaborator
Author
There was a problem hiding this comment.
This is the core of the fix. See a2660a7 for some context.
joshuay03
force-pushed
the
fix-133
branch
4 times, most recently
from
335162b to
b4ccd62
Compare
joshuay03
force-pushed
the
fix-133
branch
2 times, most recently
from
cdf432d to
3216295
Compare
joshuay03
changed the title
joshuay03
force-pushed
the
fix-133
branch
2 times, most recently
from
8a4297e to
dc422e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt at fixing #133.
Need to debug the test failures...