Enable ppc64le build for test-tools #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kabhiibm <kumar.abhishek2@ibm.com>
kabhiibm
force-pushed
the
support-ppc64le
branch
from
f75d44c to
13e6756
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables support for the ppc64le architecture in KEDA's test-tools image to expand platform compatibility for development and testing.
- Adds
ppc64learchitecture handling to the Dockerfile for Go, kubectl, and protobuf installations - Updates the Makefile to include
ppc64lein the supported build platforms - Implements architecture-specific installation logic to handle different binary naming conventions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/Dockerfile | Adds ppc64le architecture support with case statements for Go, kubectl, GitHub CLI, and protobuf installations |
| Makefile | Includes linux/ppc64le in the BUILD_PLATFORMS variable for multi-platform builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "amd64") PROTOC_ARCH="x86_64" ;; \ | ||
| "arm64") PROTOC_ARCH="aarch_64" ;; \ | ||
| "s390x") PROTOC_ARCH="s390_64" ;; \ | ||
| "ppc64el" | "ppc64le") PROTOC_ARCH="ppcle_64" ;; \ |
There was a problem hiding this comment.
The protobuf architecture name 'ppcle_64' appears to be incorrect. Based on the protobuf releases, the correct architecture name should be 'ppc_64' for ppc64le.
Suggested change
| "ppc64el" | "ppc64le") PROTOC_ARCH="ppcle_64" ;; \ | |
| "ppc64el" | "ppc64le") PROTOC_ARCH="ppc_64" ;; \ |
Member
There was a problem hiding this comment.
Please double check this, it could be a halucination
zroubalik
reviewed
Oct 7, 2025
| curl -LO "https://dl.k8s.io/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/$(dpkg --print-architecture)/kubectl.sha256" && \ | ||
| RUN ARCH=$(dpkg --print-architecture) && \ | ||
| case "$ARCH" in \ | ||
| "ppc64le" | "ppc64el") \ |
Member
There was a problem hiding this comment.
why do we have have both *le and *el?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
ppc64lesupport for thetest-toolsimage, a crucial step toward building and runningKEDAon theppc64learchitecture.Key Changes:
tools/Dockerfileto supportppc64lebuilds.Makefileto enableppc64learchitecture compatibility.With these enhancements, the
test-toolsimage can be successfully built and utilized for KEDA development onppc64le.