Skip to content

Conversation

@javisperez
Copy link
Contributor

Fixes #632 by adding a "Subscribe to KitOps" section in the home page (previously a form in the Hero section).

This also uses CF Turnstile instead of reCaptcha v3.

@javisperez javisperez self-assigned this Dec 4, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the changes in this file are just clean up from moving to a custom sitemap script to the official sitemap setting.

const isSuccess = ref(false)
const isProd = import.meta.env.PROD

isSubscribed.value = localStorage.getItem('subscribed') === 'true'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, a string, localStorage doesn't handle boolean values and TS knows it lol.

Copy link
Member

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo to be fixed before merge

</div>

<div v-if="!isSubscribed" class="mt-32 md:mt-40 xl:mt-60 px-6 md:px-12 content-container">
<h2 class="text-center">stay informed About Kitops</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stay => Stay. It should start with uppercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not a typo :D its a decision. The font renders uppercase and lowercase completely different, so we make some "play" with those to get the style that we want. Example: https://github.com/jozu-ai/kitops/blob/3c9e7aa29ebe399609b6df4488849a2faeaf9585/docs/.vitepress/theme/components/Home.vue#L200

And if i make that text capitalized, it looks like this, which is no bueno:

image

@javisperez javisperez merged commit 0afd820 into kitops-ml:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Add the newsletter form to KitOps

3 participants