-
Notifications
You must be signed in to change notification settings - Fork 160
Add "Subscribe to KitOps" section #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Subscribe to KitOps" section #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the changes in this file are just clean up from moving to a custom sitemap script to the official sitemap setting.
| const isSuccess = ref(false) | ||
| const isProd = import.meta.env.PROD | ||
|
|
||
| isSubscribed.value = localStorage.getItem('subscribed') === 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, a string, localStorage doesn't handle boolean values and TS knows it lol.
gorkem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo to be fixed before merge
| </div> | ||
|
|
||
| <div v-if="!isSubscribed" class="mt-32 md:mt-40 xl:mt-60 px-6 md:px-12 content-container"> | ||
| <h2 class="text-center">stay informed About Kitops</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stay => Stay. It should start with uppercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not a typo :D its a decision. The font renders uppercase and lowercase completely different, so we make some "play" with those to get the style that we want. Example: https://github.com/jozu-ai/kitops/blob/3c9e7aa29ebe399609b6df4488849a2faeaf9585/docs/.vitepress/theme/components/Home.vue#L200
And if i make that text capitalized, it looks like this, which is no bueno:

Fixes #632 by adding a "Subscribe to KitOps" section in the home page (previously a form in the Hero section).
This also uses CF Turnstile instead of reCaptcha v3.