Skip to content

Conversation

@simkam
Copy link

@simkam simkam commented Jan 20, 2026

This is my first ever golang contribution (obviously also the first using reconciler-test framework) so I would appreciate throught review and some patience.

This adds new tag for e2e tests called e2e_aws that runs tests for integrationsink/integrationsource resources that use AWS services. See updated test/rekt/README.md for all details.

New tests (tag) pass locally and we will run them in an internal Jenkins. We can consider also including them in GH CI.

Usual disclamer nowadays - written with help by AI - Google Gemini and Claude Code.

depends on #8851 fixing linting errors

@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jan 20, 2026
@knative-prow knative-prow bot requested review from aliok and mgencur January 20, 2026 11:47
@knative-prow
Copy link

knative-prow bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simkam
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Jan 20, 2026

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.13%. Comparing base (59b517c) to head (2ab06a5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8849      +/-   ##
==========================================
+ Coverage   51.12%   51.13%   +0.01%     
==========================================
  Files         409      409              
  Lines       21369    21369              
==========================================
+ Hits        10925    10928       +3     
+ Misses       9592     9588       -4     
- Partials      852      853       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simkam simkam force-pushed the eventing-integrations-e2e branch from f038304 to 64c72fd Compare January 20, 2026 12:22
@simkam simkam force-pushed the eventing-integrations-e2e branch from 64c72fd to 2ab06a5 Compare January 20, 2026 12:32
@knative-prow
Copy link

knative-prow bot commented Jan 20, 2026

@simkam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_main 2ab06a5 link true /test reconciler-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simkam simkam marked this pull request as draft January 20, 2026 15:07
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@simkam simkam changed the title intergrationsource/integrationsink AWS e2e tests integrationsource/integrationsink AWS e2e tests Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-and-release Test infrastructure, tests or release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant