-
Notifications
You must be signed in to change notification settings - Fork 618
integrationsource/integrationsink AWS e2e tests #8849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simkam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8849 +/- ##
==========================================
+ Coverage 51.12% 51.13% +0.01%
==========================================
Files 409 409
Lines 21369 21369
==========================================
+ Hits 10925 10928 +3
+ Misses 9592 9588 -4
- Partials 852 853 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f038304 to
64c72fd
Compare
64c72fd to
2ab06a5
Compare
|
@simkam: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is my first ever golang contribution (obviously also the first using reconciler-test framework) so I would appreciate throught review and some patience.
This adds new tag for e2e tests called
e2e_awsthat runs tests for integrationsink/integrationsource resources that use AWS services. See updatedtest/rekt/README.mdfor all details.New tests (tag) pass locally and we will run them in an internal Jenkins. We can consider also including them in GH CI.
Usual disclamer nowadays - written with help by AI - Google Gemini and Claude Code.
depends on #8851 fixing linting errors