Skip to content

backend: Add fallback for idpIssuerURL#3963

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
lszczepaniak-XM:add-fallback-for-idpIssuerURL
Sep 29, 2025
Merged

backend: Add fallback for idpIssuerURL#3963
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
lszczepaniak-XM:add-fallback-for-idpIssuerURL

Conversation

@lszczepaniak-XM
Copy link
Contributor

Summary

This PR fixes empty idpIssuerURL by setting fallback for kubeconfig field.

Related Issue

Fixes #3961

Changes

  • Added fallback for idpIssuerURL

Steps to Test

  1. Set your idpIssuerURL outside of global flag
  2. After logging in, wait for token to expire

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2025
@joaquimrocha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaquimrocha, lszczepaniak-XM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 99b57fc into kubernetes-sigs:main Sep 29, 2025
8 checks passed
@illume illume changed the title fix: add fallback for idpIssuerURL backend: Add fallback for idpIssuerURL Sep 30, 2025
@illume illume added kind/feature Categorizes issue or PR as related to a new feature. backend Issues related to the backend oidc Issue related to OIDC blocker Completely prevents the user from using the software. labels Sep 30, 2025
@illume illume added this to the v0.36.0 milestone Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backend Issues related to the backend blocker Completely prevents the user from using the software. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. oidc Issue related to OIDC size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC refresh_token doesn't work for multi cluster configuration

4 participants