-
Notifications
You must be signed in to change notification settings - Fork 576
Add appearance configuration per cluster #4357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add appearance configuration per cluster #4357
Conversation
|
I only noticed now that you have backend code related to this appearance PR. I do not think that's where the appearance should be stored. |
|
Does that mean I should also remove the warning banner? The whole point of this MR was to have a unified setup for all devs. Putting this in localstorage would remove the main idea of adding a warning. I can do it via localstorage, but do you have a link to the issue / thread regarding:
This is something that I wouldn't mind working on and is quite important for my team to continue using headlamp going forward. |
f4da90c to
1ccb8eb
Compare
|
Hi @joaquimrocha @skoeva ! Following your suggestions, I've modified the PR to only include frontend changes, the setting is now applied in the localstorage. I've also removed the warning banner to keep changes to the minimum. Here is a demo of the final result: Screen.Recording.2026-01-17.at.3.58.24.PM.movPlease let me know how that looks. Regarding being able to share those settings across users, is there something I could look into to follow progress / be able to help in any way (edit: saw the following issue: #3979)? This is something that would be very useful for me and my team to use this - it is a big UX enabler for devs having access to a shared headlamp instance to be able to easily see they are working on a prod cluster without having to set those settings themselves :) |
1ccb8eb to
e7b371c
Compare
|
@illume @skoeva @joaquimrocha @sniok any updates regarding this PR? |
|
Hi @alexmathieu22 . Thanks for the PR clean up and updates. I think it looks pretty good in your video. I am a bit concerned how a larger group of clusters will look in the side bar, but I think that the rest should be mergeable. I want to take a closer look and unfortunately didn't have time for it at all this week. Maybe next week I will able to, as I really want to have this. |
I assume you are suggesting we keep the icon for the cluster if it's just 1 cluster being shown), ideally replacing the sidebar icon we now have; and if more than one, we don't show the cluster icon at all (keep it as it was). |
Yeah, I think this will look better by default (to have no icons). It could be a default minikube, kind, k3d (and other testing clusters) icons could be good. But even then some people have like 10 test clusters... so it would have the same problem of lots of un-unique icons. |
illume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks!
(I'd like to get this in for 0.40.0 release on Thursday, code freeze on Tuesday. Might I suggest we take further design discussion to an issue? It seems to me a good improvement as it is, and we can iterate on this if needed in the next releases. Sound like a plan?)
e7b371c to
97b798d
Compare
|
@illume I have approved this changes. I think there are a couple of things we could improve but it's also in a good state already and I love having icons for clusters. |
sniok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexmathieu22, illume, joaquimrocha, sniok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ae8b927 to
971270f
Compare
9fd4ed0 to
163516f
Compare
163516f to
cc2596d
Compare
cc2596d to
5d68c0e
Compare
5d68c0e to
67dfb99
Compare
|
@alexmathieu22 I removed your merge branch hoping I am helping you land this PR. |










Summary
This PR is a rebase of this PR.
This PR adds accent colors / logo / warning message for each cluster by adding an "Appearance" section in the settings of the clusters. The color change was kept to a minimum as to not disrupt the design, but let us modify it further when a more elaborate design is approved by board. The warning message is optional and it's color is the accent color decided by user. Finally, the icon is currently an icon from the iconify library. This choice was made to kept the change as small as possible, and to use an already used library.
Related Issue
Fixes #15
Changes
Steps to Test
Screenshots (if applicable)
Notes for the Reviewer