Skip to content

Conversation

@greedy-wudpeckr
Copy link
Contributor

Summary

This PR fixes ignored k8cache error handling

Related Issue

Fixes #4509

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: greedy-wudpeckr
Once this PR has been reviewed and has the lgtm label, please assign yolossn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2026
@greedy-wudpeckr greedy-wudpeckr force-pushed the Fixed-ignored-error-handling branch from 1b97584 to 82bb10c Compare February 2, 2026 19:35
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the commit message? Have a look a the git commit guidelines in the contribution guide, and look at other git messages with git log.

It should be something closer to this:

backend: server: Fix ignored k8cache error handling

Also, please remove the signed-off-by? In this repo we don't need it as we use the CLA check. Thanks!

@illume illume closed this Feb 2, 2026
@illume illume reopened this Feb 2, 2026
@illume illume requested a review from Copilot February 2, 2026 20:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses error handling for the k8cache authentication error response function. Previously, the error returned by ReturnAuthErrorResponse was explicitly ignored, which could lead to silent failures when attempting to send authentication error responses to clients.

Changes:

  • Replaced ignored error assignment with proper error handling for k8cache.ReturnAuthErrorResponse

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greedy-wudpeckr greedy-wudpeckr force-pushed the Fixed-ignored-error-handling branch from 82bb10c to d8feb5e Compare February 2, 2026 21:21
@greedy-wudpeckr
Copy link
Contributor Author

done PTAL @illume

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm that this is not causing any lint error?.
the error was ignored to not showing lint error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

backend: server.go: Fix ignored error handling

4 participants