-
Notifications
You must be signed in to change notification settings - Fork 572
backend: Fixed ignored k8cache error handling #4525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
backend: Fixed ignored k8cache error handling #4525
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: greedy-wudpeckr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1b97584 to
82bb10c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the commit message? Have a look a the git commit guidelines in the contribution guide, and look at other git messages with git log.
It should be something closer to this:
backend: server: Fix ignored k8cache error handling
Also, please remove the signed-off-by? In this repo we don't need it as we use the CLA check. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses error handling for the k8cache authentication error response function. Previously, the error returned by ReturnAuthErrorResponse was explicitly ignored, which could lead to silent failures when attempting to send authentication error responses to clients.
Changes:
- Replaced ignored error assignment with proper error handling for
k8cache.ReturnAuthErrorResponse
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
82bb10c to
d8feb5e
Compare
|
done PTAL @illume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you confirm that this is not causing any lint error?.
the error was ignored to not showing lint error
Summary
This PR fixes ignored k8cache error handling
Related Issue
Fixes #4509