-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add kubelet pod lifecycle docs #8803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add kubelet pod lifecycle docs #8803
Conversation
Signed-off-by: lauralorenz <[email protected]>
Signed-off-by: lauralorenz <[email protected]>
|
/assign @tallclair |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lauralorenz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| The Kubelet **orchestrates** the Pod spec into running processes on the host via | ||
| the **Container Runtime Interface (CRI)**. The runtime (e.g., containerd) | ||
| translates these requests into OCI specs for `runc`, which handles the low-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for an OCI runtime (e.g. runc) maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 1e0356e
| The Kubelet **orchestrates** the Pod spec into running processes on the host via | ||
| the **Container Runtime Interface (CRI)**. The runtime (e.g., containerd) | ||
| translates these requests into OCI specs for `runc`, which handles the low-level | ||
| host syscalls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm host syscalls doesn't feel fully correct here. Maybe which handles the low-level operating system setup for the container or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked around OCI website and https://github.com/opencontainers/runtime-spec for a more precise way to say this but I can't (the word container is so overused 😓 ). Updated to use your wording in ba96155.
|
this is excellent! a couple of notes, but it's a great addition overall! |
Signed-off-by: lauralorenz <[email protected]>
Signed-off-by: lauralorenz <[email protected]>
Signed-off-by: lauralorenz <[email protected]>
|
/lgtm |
Add code docs describing kubelet sync loops with code deep links, as well as testing information. Words and thoughts are actually all plagiarized from @tallclair.
Which issue(s) this PR fixes:
No specific issue.