Skip to content

Conversation

@julien4215
Copy link
Collaborator

@julien4215 julien4215 commented Jan 28, 2026

The goal is to simplify the code by replacing a callback by a boolean in the AndroidGesturesExclusionWidget.

This was part of the PR #1921. I only took this change for now because I am not sure about the rest.

@veloce
Copy link
Contributor

veloce commented Jan 29, 2026

Please provide a description in your PR. What are you trying to solve? How? Anything that can help me understand. I don't want to figure things out just by reading the code. Thanks.

@julien4215
Copy link
Collaborator Author

julien4215 commented Jan 29, 2026

I have added a description to the PR.

Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Have you tested it to be sure it still works as expected?

@julien4215
Copy link
Collaborator Author

I have tested it. The behavior is the same as before so I think it can be merged.

However it made me realize that the gesture exclusion is broken on the game screen. The gesture exclusion happens below the board.

@veloce
Copy link
Contributor

veloce commented Jan 30, 2026

How so? I may be, but I don't understand why since this code hasn't changed.

@veloce veloce merged commit 8ac2eeb into main Jan 30, 2026
1 check passed
@veloce veloce deleted the gesture-exclusion-widget branch January 30, 2026 13:59
@julien4215
Copy link
Collaborator Author

I don't know. It works correctly on the puzzle board (well only on half of the board because of the 200 dp limit on setAndroidBoardGesturesExclusion) but it doesn't work at all for the game screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants