masonry_winit: allow configuring WGPU device request #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
force-pushed
the
masonry-winit-allow-wgpu-device-configuration
branch
2 times, most recently
from
097fb1c to
b6f097f
Compare
xStrom
reviewed
Jan 22, 2026
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Looks good overall, but the public docs need a bit of clarity.
- Add `WgpuLimits` and expose it via `masonry_winit::app`
- Add `MasonryState::{set_wgpu_device_options, add_wgpu_features, set_wgpu_limits}`
to configure requested `wgpu::Features` and limits before device creation
- Thread requested features/limits through `RenderContext::new_device` (best-effort
features via intersection with adapter features)
waywardmonkeys
force-pushed
the
masonry-winit-allow-wgpu-device-configuration
branch
from
b6f097f to
134f3f2
Compare
xStrom
approved these changes
Jan 23, 2026
waywardmonkeys
deleted the
masonry-winit-allow-wgpu-device-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WgpuLimitsand expose it viamasonry_winit::appMasonryState::{set_wgpu_device_options, add_wgpu_features, set_wgpu_limits}to configure requestedwgpu::Featuresand limits before device creationRenderContext::new_device(best-effort features via intersection with adapter features)