adding mqtt user feature that works around the paho mqtt 340 connections limit issue #3268
+95
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionutab
changed the title
Collaborator
Maybe make it a flag in MqttUser instead (passed on to MqttClient triggering a replace of the _loop method in its constructor)? If this is a good fix, maybe it should even be the default? Perhaps we should log a warning if someone tries to launch >340 connections with the default setup? |
Contributor
Author
|
Good ideas. I'll see what I can do. Thanks! |
ionutab
force-pushed
the
feature/mqtt_experimental
branch
from
4ebb94b to
879b84c
Compare
ionutab
changed the title
Contributor
Author
|
I've made the update. I'm not sure where to add the validation for the 340 warning message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There's a limitation caused by the use of
selectin the paho.mqtt.python library.eclipse-paho/paho.mqtt.python#697
The purpose of this PR is to provide an implementation of
MqttClientthat has an overriden_loopmethod that usesselectorsinstead ofselect.The implementation was initially posted on the solution above, by @j04n-f
Please advise on:
🤔 I'm not sure about the
Experimentalname.📌 Code placement in a separate file.
🧀 If any specific tests are desired and or necessary.
🩻 What better example I could provide.
After the implementation is confirmed I will add documentation and README file updates.
Thanks!