Fix cursor disappear and rendering issue with Chinese characters #608
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching between Block and I-beam cursor shapes on wide characters (e.g. Chinese), the cursor area was too narrow due to using _fontWidth instead of the actual character pixel width. This caused visual artifacts such as partial cursor remnants or incomplete redraw. This change uses QFontMetrics::horizontalAdvance() to get the true width of the character under the cursor, while preserving the existing -1/+1 adjustment to maintain I-beam visibility under sub-pixel rendering.
Author
|
qterminal before after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching between Block and I-beam cursor shapes on wide characters (e.g. Chinese), the cursor area was too narrow due to using _fontWidth instead of the actual character pixel width. This caused visual artifacts
such as partial cursor remnants or incomplete redraw.
This change uses QFontMetrics::horizontalAdvance() to get the true width of the character under the cursor, while preserving the existing -1/+1 adjustment to maintain I-beam visibility under sub-pixel rendering.