Skip to content

Conversation

@basil
Copy link

@basil basil commented Feb 1, 2026

Fixes #586. Tested by reproducing the issue before this PR; could no longer reproduce after this PR.

@tsujan
Copy link
Member

tsujan commented Feb 1, 2026

Thank you very much! I'll review it as soon as possible.

@basil basil changed the title Extraenous 5u appears on the terminal when using fish shell Extraneous 5u appears on the terminal when using fish shell Feb 1, 2026
@tsujan
Copy link
Member

tsujan commented Feb 3, 2026

For some reason unknown to me, fish (4.3.3) doesn't show 5u here anymore without this patch, although I removed ~/.config/fish.

But there's another way to test without fish (→ #586 (comment)). Without the patch printf '\x1b[=9L' shows 9L, while with the patch it shows nothing. So, quite a progress!

However, printf '\x1b[2:=z' and printf '\e[===s' should show nothing (see the table in the above link), as is the case with XTerm and Konsole, but with the patch z and =s are still shown respectively.

@basil
Copy link
Author

basil commented Feb 3, 2026

I'm aware of that. The scope of this PR was to fix the issue with a single equals sign, not to fix those other issues.

@tsujan
Copy link
Member

tsujan commented Feb 3, 2026

The scope of this PR was to fix the issue with a single equals sign

I appreciate your code, but since the original issue isn't reproducible with fish 4.3.3, I'm not sure it's enough.

Or can someone reproduce it with a recent version of fish? @stefonarch, @marcusbritanicus?

@basil basil closed this Feb 3, 2026
@basil basil deleted the emulation branch February 3, 2026 16:51
@tsujan
Copy link
Member

tsujan commented Feb 3, 2026

Why did you close it?!

@tsujan
Copy link
Member

tsujan commented Feb 3, 2026

OK, the answer is #613. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extraenous 5u appears on the terminal when using fish shell

2 participants