Fix for avatar image not being saved in disk cache on GTK version #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
== Symptom Avatar icon in the desktop notification (libnotify) of GTK version was missing. == Cause Save to disk operation was aborted due to an exception in the `get_prefs` function on agent.py, as it was trying to fetch a non-existing element (proxy_type) from config.settings dictionary. == Solution Check if the key exists in the dictrionary before using it, and return an empty string if not.
ghost
assigned
Note: ignoring white spaces
…names As of today, Twitter only allow letters, numbers and _ (undescore) in the handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom
Avatar icon in the desktop notification (libnotify) of GTK version was missing.
Cause
Save to disk operation was aborted due to an exception in the
get_prefsfunction on agent.py, as it was trying to fetch a non-existing element
(proxy_type) from config.settings dictionary.
Solution
Check if the key exists in the dictrionary before using it, and return an empty
string if not.