-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[GIT-57 | WEB-5912] fix: app sidebar ux and responsiveness #8560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: preview
Are you sure you want to change the base?
Conversation
|
Linked to Plane Work Item(s) References
This comment was auto-generated by Plane |
📝 WalkthroughWalkthroughThese changes refine sidebar navigation behavior by adding mobile-specific click prevention to the resizable sidebar, extending the project navigation component to manage the extended sidebar state, and refining projects list item click handling to respect accordion mode. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes app sidebar UX issues and improves mobile responsiveness by ensuring the extended project sidebar is properly closed in accordion mode and when navigating to project items.
Changes:
- Modified sidebar behavior to prevent extended sidebar from closing in accordion mode when clicking project items
- Added logic to close extended sidebar when navigating within project items
- Added mobile-specific attribute to prevent outside click handling on the resizable sidebar
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/web/core/components/workspace/sidebar/projects-list-item.tsx |
Moved isAccordionMode variable declaration earlier and added condition to prevent closing extended sidebar in accordion mode |
apps/web/core/components/workspace/sidebar/project-navigation.tsx |
Added logic to close extended sidebar when clicking navigation items |
apps/web/core/components/sidebar/resizable-sidebar.tsx |
Added data-prevent-outside-click attribute for mobile devices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR fixes app sidebar ux and mobile responsiveness.
Type of Change
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.