Skip to content

Conversation

@dakejahl
Copy link
Collaborator

Replace ternary null-guards with optional chaining for nested Fact property access

Follow up from #13866

Needs to be fully tested

  Use optional chaining (?.) and nullish coalescing (??) to safely
  access nested properties on vehicle/object Facts that may be
  undefined during initialization.

  Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

Pre-commit Checks Failed

Status Count
Passed 13
Failed 46
Hook Results
check yaml...............................................................Passed
check json...............................................................Passed
pretty format json.......................................................Failed
check xml................................................................Passed
check for merge conflicts................................................Passed
check for added large files..............................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
mixed line ending........................................................Passed
TruffleHog...............................................................Passed
clang-format.............................................................Failed
clang-tidy...............................................................Failed
ruff (legacy alias)......................................................Failed
ruff format..............................................................Failed
pyright..................................................................Failed
shellcheck...............................................................Failed
cmake-format.............................................................Failed
cmake-lint...............................................................Failed
Lint GitHub Actions workflow files.......................................Failed
yamllint.................................................................Passed
markdownlint.............................................................Failed
vale.....................................................................Failed
typos....................................................................Failed
Lint QML files...........................................................Failed
Qt static analysis (clazy)...............................................Passed
Check for Q_ASSERT in production code....................................Passed
Check vehicle null safety................................................Failed
Files Modified by Hooks
 .github/workflows/pr-checks.yml                | 1 -
 src/Utilities/Compression/CMakeLists.txt       | 2 --
 test/Utilities/FileSystem/QGCFileHelperTest.cc | 1 -
 3 files changed, 4 deletions(-)

How to Fix

./tools/pre-commit.sh
git add -u && git commit --amend --no-edit

Run ID: 20983329937

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Artifact Sizes

Artifact Size
QGroundControl.dmg 311.72 MB

No baseline available for comparison

Updated: 2026-01-14 06:20:22 UTC • Triggered by: MacOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants