Skip to content

Conversation

@kohalmykristof
Copy link
Contributor

@kohalmykristof kohalmykristof commented Jan 23, 2026

Description

Problem

Preflight checklist UI doesn't work in case of VTOL vehicle class.

Solution

Add the VTOLChecklist.qml file to the CMakeLists.txt of the FlyView.

Note: should we update this on the Stable_V5.0 branch too? (folder renamed in path: [https://github.com/mavlink/qgroundcontrol/blob/Stable_V5.0/src/FlightDisplay/CMakeLists.txt])

Testing

I tested it with a Stable_V5.0 custom build using ArduPilot on a PixHawk 6C. However, this fix belongs to the main branch. Excuse me the lack of capacity for proper testing. Thus, I create this pull request as a draft suggestion only.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Flight Stacks Tested

  • PX4
  • ArduPilot

Screenshots

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

Related Issues


By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

…reflight checklist UI doesn't work in case of vtol vehicle class
@github-actions
Copy link
Contributor

Thanks for your first pull request! 🎉

A maintainer will review this soon. Please ensure:

  • CI checks pass
  • Code follows coding standards
  • Changes tested on relevant platforms

We appreciate your contribution to QGroundControl!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Test Results

linux_gcc_64: 479 passed, 0 skipped

Total: 479 passed, 0 skipped

Code Coverage

Coverage: 100.0%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl-aarch64.AppImage 187.03 MB
QGroundControl-installer-AMD64-ARM64.exe 74.54 MB
QGroundControl-installer-AMD64.exe 162.39 MB
QGroundControl-installer-ARM64.exe 75.34 MB
QGroundControl-mac.apk 159.48 MB
QGroundControl-windows.apk 159.50 MB
QGroundControl-x86_64.AppImage 174.84 MB
QGroundControl.apk 312.22 MB
QGroundControl.dmg 311.46 MB

No baseline available for comparison

Updated: 2026-01-23 17:25:56 UTC • Triggered by: MacOS

@DonLakeFlyer DonLakeFlyer self-requested a review January 23, 2026 18:44
@DonLakeFlyer
Copy link
Collaborator

Yup, this fixes it. Thanks

@DonLakeFlyer DonLakeFlyer marked this pull request as ready for review January 23, 2026 18:50
Copilot AI review requested due to automatic review settings January 23, 2026 18:50
@DonLakeFlyer DonLakeFlyer merged commit 4795847 into mavlink:master Jan 23, 2026
21 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical build bug where the VTOLChecklist.qml file was missing from the FlyView module's CMakeLists.txt, causing the preflight checklist UI to fail for VTOL vehicle types.

Changes:

  • Added VTOLChecklist.qml to the QML_FILES list in src/FlyView/CMakeLists.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants