-
Notifications
You must be signed in to change notification settings - Fork 24
feat(baseline): include data for discouraged features #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
a593f82 was deployed to: https://rari-pr311.review.mdn.allizom.net/ |
|
|
||
| static FEATURE_MDN_URLS: LazyLock<IndexMap<&'static str, &'static str>> = LazyLock::new(|| { | ||
| [ | ||
| ("async-clipboard", "/docs/Web/API/Clipboard_API"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if web-features could add an mdn field: https://github.com/web-platform-dx/web-features/blob/96d7e3c4e91500cf84f31cbab590f539566980ae/features/async-clipboard.yml#L1-L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been talking about how best to maintain the web-feature <--> mdn mapping: once we've decided (and implemented) that, I'm sure we'll be able to add an mdn field to web-features.
Perhaps for these "features pointed at by discouraged features" it makes sense to add them manually in the web-features repo though
Opening as draft so this isn't merged without the corresponding fred change: nothing should break if we merge it before, but according to my local diff we'll have 4 baseline high banners appear where we'd want a discouraged banner instead.
Relates to: mdn/fred#654
Allows data for discouraged features to be included in our index.jsons, while maintaining the same asterisk logic as before: a discouraged feature is treated as having no baseline status. Without the asterisk logic change, the font page loses its asterisk.