-
Notifications
You must be signed in to change notification settings - Fork 24
feat(macros): remove mdn-data dependency #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…into 369-remove-mdn-data-dependency
…into 369-remove-mdn-data-dependency
Should be good once the dependency on the content PR for the new l10n file has landed. Tests run fine for me locally. |
Maybe tests just run fine locally, because your cached |
…nd run it before the tests
|
Kicked off test deployment: https://github.com/mdn/dex/actions/runs/20141208343 |
Description
CSSInfomacroThis removes the dependency on mdn-data for the
{{cssinfo}}macro. Data now comes solely from the contents ofwebref/css, except for translations of the values. The latter are now in a new translation file, living incontent.This is about the Formal defintion blocks on the CSS reference pages. These show up potentially on CSS
propertiesand@-rule descriptors.The legacy mdn-data-sourced localizations contained md/html/macro-enhanced content at times, linking to the data via enumerations. These enumerations along with any localizations, are not available in webref/css. After discussion with the content team it was deemed to be more important to reflect the specs from webref/css properly than any markup-regression we will see with this new approach.
The keys (
inherited,animation type, …) are still translated as before, sourcing translations fromcontent/files/jsondata/L10n-Template.jsonValues are now translated from a new file in
content/files/jsondata/L10n-CSSFormalDefinition.json. All translated languages are missing currently and can be filled in later. The current file includes the en-US values copied straight from the key.CSS_refmacroThis macro used to be based on
mdn-data, with numerous dead links in the resulting list. Since content has shifted away from the Wiki-style "link first, create the page second" mantra, we now base this macro on the actual content in the file system. This is in line with another macro{{APIListAlpha}}that simply walks the file system. This obviously removes the dependency onmdn-dataMotivation
Getting rid of mdn-data and go directly to the source.
Additional details
Related issues and pull requests
This depends on mdn/content#42241 to land before deploying.
Fixes #369.