Adding hyperlink to 'New: Kanvas Snapshots' #78
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview deployment for PR #78 🌐 Preview URL: https://meshery-extensions.github.io/kanvas-site/pr-preview/pr-78/ This preview will be updated automatically when you push new commits to this PR. |
Katotodan
reviewed
Jan 31, 2026
There was a problem hiding this comment.
It wouldn't be better to completely remove the span tag?
And add its class to the a tag?
I don't see the utility of having that span there any longer.
Is just a suggestion
Contributor
Author
There was a problem hiding this comment.
@Katotodan You are right. I will remove the redundant and move the pill class directly to the tag. This definitely makes the DOM cleaner. Thanks for the catch!
Updated the link and moved the .pill class directly to the anchor tag for a cleaner DOM structure, as suggested during review. Signed-off-by: Kunal Anand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #76
hero-glass.htmlfile, introducing a "New: Kanvas Snapshots" pill that links users to the relevant documentation.Signed commits
Changes:
hero-glass.htmlto include the link and span with the.pillclass.