modules/rust: Attempt to extract --target arguments from rustc command
#15453
+102
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logic looks good to me. |
dnicolodi
reviewed
Jan 15, 2026
dcbaker
force-pushed
the
submit/bindgen-extract-rust-target
branch
from
a12789e to
1853b04
Compare
dcbaker
force-pushed
the
submit/bindgen-extract-rust-target
branch
3 times, most recently
from
57f8adb to
464f988
Compare
dnicolodi
reviewed
Jan 16, 2026
dcbaker
force-pushed
the
submit/bindgen-extract-rust-target
branch
from
464f988 to
4ce6021
Compare
dcbaker
force-pushed
the
submit/bindgen-extract-rust-target
branch
from
4ce6021 to
3b33305
Compare
dnicolodi
reviewed
Jan 22, 2026
This will look for `--target` and `--target=` in the configured rust command, but only if `--target` or `--target=` has not been passed in the bindgen_clang_args of the machine file. I've added a unittest for this that tests all four possible conditions. I've used a new custom test that is minimal rather than reusing the bindgen test in the rust directory, as it cuts this test's runtime in half doing so. Fixes: mesonbuild#13591 Co-authored-by: Daniele Nicolodi <[email protected]>
dcbaker
force-pushed
the
submit/bindgen-extract-rust-target
branch
from
b0c2fd8 to
ff155ef
Compare
Member
Author
|
I'm planning to merge this Monday unless there objections before then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will look for
--targetand--target=in the configured rust command, but only if--targetor--target=has not been passed in the bindgen_clang_args of the machine file.TODO: still needs tests.
Fixes: #13591