Skip to content

Enabled code linting with ruff #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phw merged 7 commits into from
Jan 19, 2026
Merged

Enabled code linting with ruff #59

phw merged 7 commits into from
Jan 19, 2026

Conversation

@phw
Copy link
Member

@phw phw commented Jan 19, 2026

  • Enabled code linting with "ruff check"
  • Added pre-commit and setup pre-commit config to run "ruff check" and pytest
  • Added CI workflow to run "ruff check"
  • Applied some code fixes
    • Do not use mutable objects as default parameters. This affected the features parameter in read
    • Refactored the _decode and _encode util functions

@phw phw requested a review from zas January 19, 2026 07:50
zas
zas approved these changes Jan 19, 2026
View reviewed changes
Copy link

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 6f943f7 into metabrainz:main Jan 19, 2026
7 checks passed
@phw phw deleted the ruff-lint branch January 19, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zas zas zas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phw @zas