Fix issue when several routes match current path #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, doing:
```javascript
Picker.route('somePath', (params, req, res, next) => {
if (req.method == 'POST') {
...
} else { next(); }
});
Picker.route('somePath', (params, req, res, next) => {
if (req.method == 'GET') {
...
} else { next(); }
});
```
will not reach the GET route if the request is `GET somePath`. If you accept the PR, it's be good to update picker's version and the dependency in flow-router-ssr at https://github.com/kadirahq/flow-router/blob/ssr/package.js#L61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, doing:
will not reach the GET route if the request is
GET somePath.For any other example where several route definitions match the current path, calling next will not go to the next definition.
If you accept the PR, it's be good to update picker's version and the dependency in flow-router-ssr at https://github.com/kadirahq/flow-router/blob/ssr/package.js#L61