Skip to content

Conversation

@maxtropets
Copy link
Collaborator

@maxtropets maxtropets commented Jan 20, 2026

Closes #7479.

@maxtropets maxtropets self-assigned this Jan 20, 2026
Copilot AI review requested due to automatic review settings January 20, 2026 21:22
@maxtropets maxtropets requested a review from a team as a code owner January 20, 2026 21:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables the UVM endorsements test for version 0.2.10 and adds support for the new application/octet-stream content type format. The changes properly handle both legacy JSON-based endorsements and the new binary format that carries the SVN in CWT claims.

Changes:

  • Added new constant for application/octet-stream content type
  • Restructured content type validation to support both legacy and new endorsement formats
  • Updated test data and assertions for UVM 0.2.10 with corrected measurements and EKU values

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/uvm_endorsements/uvm_0.2.10.cose New binary test file containing COSE-signed UVM endorsements
src/node/cose_common.h Added constant for application/octet-stream content type
src/node/uvm_endorsements.cpp Restructured content type validation based on SVN presence in CWT claims
src/node/test/endorsements.cpp Updated test with correct measurement hash, EKU value, and re-enabled assertions

@achamayou
Copy link
Member

Shall this be backported to 6.x?..

This is not a bugfix, and there is no immediate plan from ACI to stop providing the endorsements in the old format, so there is no reason I can see to backport it to 6.x.

@achamayou achamayou merged commit cc40c8e into microsoft:main Jan 21, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable hash-envelope UVM endorsements test

2 participants