Rendering Engine Fixes [Rebase & FF] #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter Verify `mParentGop` is valid before use. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
1. Open the `mMsGopOverrideProtocolGuid` in the `Start()` function with the attributes of `EFI_OPEN_PROTOCOL_BY_DRIVER` so that `SREDriverStop()` will be called by `DisconnectController()` 2.`InitializeRenderingEngine()` installs `gEfiGraphicsOutputProtocolGuid` onto the `mSREGopHandle` handle. `SREDriverStop()` uninstalls `gEfiGraphicsOutputProtocolGuid` on `mImageHandle`. This change updates the uninstall to use `mSREGopHandle` instead. Also, `UninstallMultipleProtocolInterfaces()` takes pointers not double pointers, so the casts are updated accordingly. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kuqin12
approved these changes
Jan 23, 2026
apop5
approved these changes
Jan 23, 2026
vineelko
reviewed
Jan 23, 2026
vineelko
approved these changes
Jan 23, 2026
joschock
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MsGraphicsPkg/RenderingEngineDxe: Defensive checks for global GOP pointer
Verify
mParentGopis valid before use.MsGraphicsPkg/RenderingEngineDxe: Defensive checks for global GOP pointer
Verify
mParentGopis valid before use.How This Was Tested
"disconnect -r"succeedsIntegration Instructions