-
Notifications
You must be signed in to change notification settings - Fork 256
Add enable_profiling in Runtime Options
#1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xiaofeihan1
wants to merge
9
commits into
main
Choose a base branch
from
xiaofeihan/runtimeoption_profiling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
reviewed
Feb 3, 2026
Collaborator
baijumeswani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There seem to be some merge conflicts. Once that is resolved and ort-genai 0.12.0 is out, we can merge this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previously, developers could only enable profiling through genai_config.json, which profiles the entire lifetime of a session—from session creation to session destruction. When the number of runs is large (for example, generating ~3000 tokens during inference), the profiling output can become excessively large, causing profiling to fail due to oversized files.
Description
This PR addresses this limitation by introducing run-level profiling. We expose
enable_profilinginRuntimeOptions. Developers can now enable profiling for specific runs only.With the following code, two profiling JSON files will be generated using the
run_profiler_fileprefix:• one containing profiling data for the 100th run
• another containing profiling data for the 101th run