Set delays to 0 #2971
Merged
Set delays to 0 #2971
+19
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszomoru
previously approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes timer handling in retry logic tests by replacing vi.advanceTimersByTimeAsync() with vi.runAllTimersAsync(). This change makes the tests more robust and maintainable by eliminating hardcoded delay values.
Changes:
- Replaced all instances of
vi.advanceTimersByTimeAsync()withvi.runAllTimersAsync()for timer advancement in test cases - Updated associated comments to reflect the new approach without referencing specific millisecond values
chrmarti
force-pushed
the
chrmarti/professional-catshark
branch
from
631e081 to
0b1ec48
Compare
lszomoru
previously approved these changes
Jan 19, 2026
chrmarti
force-pushed
the
chrmarti/professional-catshark
branch
from
8d1828e to
c18d10e
Compare
ulugbekna
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/microsoft/vscode-internalbacklog/issues/6543