Skip to content

Conversation

@amureki
Copy link
Member

@amureki amureki commented Jan 20, 2026

Describe the change
As JSONField is supported since Django 3.1 :)

PR Checklist

  • Change is covered with tests
  • CHANGELOG.md is updated if needed

Summary by CodeRabbit

  • Tests

    • Streamlined test setup by removing conditional test skipping; field-related tests now execute consistently.
  • Chores

    • Removed compatibility workarounds from test infrastructure, improving code maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@amureki amureki self-assigned this Jan 20, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

The PR removes conditional import handling and test skip logic for JSONField in the test suite, simplifying the codebase by assuming JSONField availability as a standard Django feature.

Changes

Cohort / File(s) Summary
Changelog update
CHANGELOG.md
Added unreleased entry documenting removal of JSONField test workarounds.
JSONField import simplification
tests/test_filling_fields.py
Removed try/except ImportError block and PostgresJSONField alias; added direct JSONField import from django.db.models; removed @pytest.mark.skipif decorator that conditionally skipped tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 No more workarounds, no skipped test lines,
JSONField's here to stay, everything aligns!
Clean imports, simpler code—a rabbit's delight,
Django's dependencies managed just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title directly and clearly describes the main change: removing JSONField workarounds from tests, which is exactly what the changeset accomplishes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@amureki amureki merged commit e4d32ca into main Jan 20, 2026
45 checks passed
@amureki amureki deleted the jsonfield branch January 20, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants