Skip to content

feat: show progress messages on initialization, for reassurance #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wally-crunk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: show progress messages on initialization, for reassurance #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions src/fertilizer/scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,16 +146,21 @@ def scan_torrent_directory(


def __collect_infohashes_from_files(files: list[str]) -> dict:
infohash_dict = {}

for filepath in files:
try:
torrent_data = get_bencoded_data(filepath)

if torrent_data:
infohash = calculate_infohash(torrent_data)
infohash_dict[infohash] = filepath
except Exception:
continue

return infohash_dict
print(f"\rStarting up. Collecting infohashes...")
print(f"\rFound {len(files)} files to process...")
Comment on lines +149 to +150
Copy link
Owner

@moleculekayak moleculekayak Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my curiosity, what's the purpose of the carriage returns at the start of the lines? Since print includes a newline, shouldn't the carriage return be unneeded?

Copy link
Author

@wally-crunk wally-crunk Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, the only \r that is truly needed is the one in print(f"\r({processed}/{len(files)})…
because it is trying to overwrite the current output line.

infohash_dict = {}

for filepath in files:
try:
torrent_data = get_bencoded_data(filepath)
if torrent_data:
infohash = calculate_infohash(torrent_data)
infohash_dict[infohash] = filepath
except Exception:
continue
processed += 1
print(f"\r({processed}/{len(files)}) Analyzing torrent files...", end="", flush=True)

print() # New line after progress complete
print(f"\rDone collecting infohashes.")
return infohash_dict