-
Notifications
You must be signed in to change notification settings - Fork 1
Add Wissler syndrome #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Wissler syndrome #200
Conversation
|
Claude finished @caufieldjh's task —— View job PR Review: Add Wissler syndromeReview Checklist
🔍 Code Quality ReviewOverall Assessment: HIGH QUALITY ✅ 📋 Detailed Findings✅ Strengths
|
|
Claude finished @caufieldjh's task —— View job PR Review: Add Wissler syndromeReview Checklist
🔍 Code Quality ReviewOverall Assessment: HIGH QUALITY ✅ 📋 Detailed Findings✅ Strengths
|
|
Claude finished @caufieldjh's task —— View job PR Review: Add Wissler syndromeReview Checklist
🔍 Code Quality ReviewOverall Assessment: HIGH QUALITY ✅ 📋 Detailed Findings✅ Strengths
✅ Code Quality & Best Practices
✅ Performance Considerations
✅ Security Assessment
|
| - name: Recurrent high fever | ||
| category: Systemic | ||
| frequency: FREQUENT | ||
| phenotype_term: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have qualifiers for recurrent + high
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| phenotype_term: | |
| - name: Recurrent high fever | |
| category: Systemic | |
| frequency: FREQUENT | |
| phenotype_term: | |
| preferred_term: Recurrent fever | |
| term: | |
| id: HP:0001954 | |
| label: Recurrent fever | |
| qualifiers: | |
| - HIGH | |
| evidence: |
Using HP:0001954 "Recurrent fever" which better captures the recurrent nature, plus a HIGH qualifier for fever severity. This is a more specific term than HP:0001945 "Fever" and includes the recurrence semantics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not apply suggestion. The suggested replacement is fine but the placement is wrong. See #197
| - name: Polymorphous exanthema | ||
| category: Dermatological | ||
| frequency: FREQUENT | ||
| phenotype_term: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit more general than the actual term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| phenotype_term: | |
| - name: Polymorphous exanthema | |
| category: Dermatological | |
| frequency: FREQUENT | |
| phenotype_term: | |
| preferred_term: Exanthem | |
| term: | |
| id: HP:4000054 | |
| label: Exanthem | |
| evidence: |
Using HP:4000054 "Exanthem" which is defined as "A widespread rash" - more specific than the generic "Skin rash" (HP:0000988). The polymorphous nature can be captured in the name field while the term anchors it to the concept of a widespread eruption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not apply suggestion. The suggested replacement is fine but the placement is wrong. See #197
| supports: SUPPORT | ||
| snippet: "The authors report a case with chronic pericardo-myocarditis progressing over a 7 year period to refractory congestive cardiac failure." | ||
| explanation: The case report documents progression to refractory congestive heart failure. | ||
| biochemical: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs terms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Biochemical class in the current schema does not have a biomarker_term or measurement_term slot. However, MAXO does have relevant terms:
MAXO:0035093- erythrocyte sedimentation rate measurementMAXO:0000551- C-reactive protein biomarker assessment
Options:
- Add these MAXO terms to the disease-level notes/context until the schema supports biomarker terms
- Propose a schema enhancement to add a
measurement_termslot to the Biochemical class - Keep as-is with the existing freetext name field
The existing entries are correctly capturing the presence/elevation status; adding formal term bindings would require schema modification.
| snippet: "Blood sample analysis revealed high levels of CRP (42.9 mg/dL, normal: 0–0.3), erythrocyte sedimentation rate (113 mm/h normal: 2–20)" | ||
| explanation: The case report documents markedly elevated CRP as part of the inflammatory syndrome. | ||
| progression: | ||
| - phase: Onset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs terms
| supports: SUPPORT | ||
| snippet: "Zunächst haben nur die Pädiater die Krankheit gesehen, neuerdings sind aber auch Fälle bei Erwachsenen bekanntgegeben worden." | ||
| explanation: The abstract notes that early reports were pediatric, with adult cases reported later. | ||
| - phase: Chronic course |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs terms
| supports: SUPPORT | ||
| snippet: "The long-term evolution is marked by recurrent febrile exacerbations, sometimes complicated by pericardo-myocarditis which usually resolves without sequellae." | ||
| explanation: The abstract summarizes recurrent febrile exacerbations and possible cardiac complications over time. | ||
| epidemiology: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are slightly odd entries for epidemiology
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These epidemiology entries describe historical publication patterns rather than population-level disease metrics. Options:
- Move to notes section - These are meta-observations about literature rather than true epidemiology
- Keep but rename - Change to "Historical context" or similar if there is a suitable slot
- Remove - If this information does not fit the schema intent
The entries would better fit a "historical_context" or "notes" field since they describe where the disease was recognized/published rather than incidence/prevalence data.
| treatments: | ||
| - name: Nonsteroidal anti-inflammatory drugs | ||
| description: NSAIDs can reduce fever and inflammatory symptoms. | ||
| treatment_term: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be improved
- there is specific term in MAXO for NSAID class
- the therapy is actually combination therapy. We recently started introducing some patterns for this with the latest batch of cancer terms but this is not well documented yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| treatment_term: | |
| - name: Nonsteroidal anti-inflammatory drugs | |
| description: NSAIDs can reduce fever and inflammatory symptoms. | |
| treatment_term: | |
| preferred_term: NSAID therapy | |
| term: | |
| id: MAXO:0000221 | |
| label: NSAID therapy | |
| evidence: |
MAXO:0000221 "NSAID therapy" is the appropriate class-level term for NSAID treatment. This avoids needing the complex pharmacotherapy+qualifier pattern and directly anchors to the specific treatment modality. The specific agent (naproxen) is mentioned in the evidence.
| supports: SUPPORT | ||
| snippet: "A combination of nonsteroidal anti-inflammatory drugs and steroids achieved complete remission." | ||
| explanation: The case report documents remission with NSAID therapy. | ||
| - name: Corticosteroids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit of a mishmash of things at different levels of granularity and the evidence doesn't seem to be precisely supporting what is said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entry mixes a class-level treatment term (corticosteroids) with specific drug evidence (prednisolone) and combination therapy evidence. Suggestions:
- Use MAXO class term:
MAXO:0000640"corticosteroid agent therapy" is more appropriate than the generic pharmacotherapy+qualifier pattern - Clarify scope: The evidence shows steroids used in combination (NSAID+steroid, azathioprine+steroid) - either split by combination regimen or note this is a component of combination therapy
- name: Corticosteroids
description: Systemic corticosteroids (e.g., prednisolone) used as part of combination regimens to control inflammation.
treatment_term:
preferred_term: corticosteroid agent therapy
term:
id: MAXO:0000640
label: corticosteroid agent therapyThe evidence references combination regimens; the other treatment entries can cross-reference or we can consolidate into combination entries per the reviewer's later comments.
| explanation: The case report notes complete remission with steroids plus NSAIDs. | ||
| - reference: PMID:1210460 | ||
| supports: SUPPORT | ||
| snippet: "In the present case the disease could successfully be controlled using imuran in combination with corticosteroids." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - the evidence for dapsone clearly shows it was used as part of a 3-drug combination (naproxen + dapsone + prednisolone). Options:
- Restructure as combination therapy entry: Create a single treatment entry representing the combination regimen
- Add explicit notes: Note in description that dapsone was used as part of combination therapy with NSAIDs and corticosteroids
- Cross-reference: Add a notes field indicating "Used in combination with corticosteroids and NSAIDs"
The current schema may not have a formal "combination_therapy" slot. If this is a pattern seen across cancer entries, we could adopt that pattern here as well.
| supports: SUPPORT | ||
| snippet: "In the present case the disease could successfully be controlled using imuran in combination with corticosteroids." | ||
| explanation: The abstract indicates corticosteroids were part of successful therapy. | ||
| - name: Dapsone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine but better to be explicit about combos
| supports: SUPPORT | ||
| snippet: "A combination of naproxen, dapsone, and prednisolone therapy resulted in significant improvement of the patient’s arthralgias and rash." | ||
| explanation: The case report documents improvement with dapsone as part of combination therapy. | ||
| - name: Azathioprine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - the azathioprine entry should clearly indicate combination therapy with corticosteroids. The evidence states "imuran in combination with corticosteroids."
Suggested restructure:
- name: Azathioprine plus corticosteroids
description: Immunosuppressive combination therapy using azathioprine with corticosteroids for disease control.
treatment_term:
preferred_term: immune suppressant agent therapy
term:
id: MAXO:0000297
label: immune suppressant agent therapy
notes: Combination regimen - azathioprine (imuran) with corticosteroidsOr if MAXO has a specific combination therapy term, that would be preferable.
cmungall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good but needs some work on the treatments. I think better to say less with controlled terms for now, focus on the strings not things
Editorial Review Bot SummaryPR Scanned: #200 (Add Wissler syndrome)
Details
Reviewer Action Required
|
No description provided.