crypto: add function sc_1() #9826
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzadiko
reviewed
Mar 29, 2025
|
|
||
| void sc_1(unsigned char *s) { | ||
| int i; | ||
| s[0] = 1; |
Contributor
There was a problem hiding this comment.
I don't know anything about cryptography, but what's to stop someone from accidentally passing in an empty character array? Why not have sc_1(unsigned char[32]) or sc_1(std::array<unsigned char, 32>&)?
Contributor
Author
There was a problem hiding this comment.
Nothing, the convention is to assume a 32 byte buffer. A signature of unsigned char[32] might be better, I was just sticking with what was currently done. std::array<unsigned char, 32>& would be incompatible with our current crypto types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of upstreaming Carrot