[LG-5932, LG-5934] refactor,feature(chat) Compound MessageFeed #3488
+235
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afygreen-ui into LG-5932-message-feed-compound
🦋 Changeset detectedLatest commit: bd83d5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors MessageFeed into a compound component and introduces a new context provider. The changes prepare the component for more flexible composition while temporarily removing the assistant name display from messages.
Changes:
- Refactored
MessageFeedto use theCompoundComponentpattern - Added
MessageFeedContextwith provider and custom hook for managing feed state - Removed assistant avatar and name display from non-sender messages in
Messagecomponent
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| chat/message/src/Message/Message.tsx | Removes assistant avatar/name rendering and related dependencies |
| chat/message-feed/src/MessageFeedContext/index.ts | Exports new context provider and hook |
| chat/message-feed/src/MessageFeedContext/MessageFeedContext.types.ts | Defines types for the MessageFeed context |
| chat/message-feed/src/MessageFeedContext/MessageFeedContext.tsx | Implements context provider and hook with error boundary |
| chat/message-feed/src/MessageFeedContext/MessageFeedContext.spec.tsx | Adds test coverage for the context hook |
| chat/message-feed/src/MessageFeed/MessageFeed.tsx | Wraps component with CompoundComponent wrapper |
| chat/message-feed/shared.types.ts | Defines subcomponent property constants for compound pattern |
| .changeset/dark-pots-tell.md | Documents changes for release notes |
chat/message-feed/src/MessageFeedContext/MessageFeedContext.tsx
Outdated
Show resolved
Hide resolved
shaneeza
requested review from
adamrasheed and
stephl3
and removed request for
a team
Contributor
|
Size Change: +63 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Contributor
|
Coverage after merging LG-5932-message-feed-compound into s/initial-message-integration will be
Coverage Report for Changed Files
|
|||||||||||||||||||
stephl3
requested changes
Jan 27, 2026
.changeset/dark-pots-tell.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@lg-chat/message-feed': path | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| '@lg-chat/message-feed': path | |
| '@lg-chat/message-feed': patch |
Collaborator
There was a problem hiding this comment.
actually, this should be a minor since we're adding this context feature
adamrasheed
reviewed
Jan 28, 2026
| } | ||
| ] | ||
| } | ||
| } |
| }, | ||
| ), | ||
| { | ||
| displayName: 'MessageFeed', |
Collaborator
There was a problem hiding this comment.
do we need to add a key here? I dont have too much context on the larger project but im not sure where MessageFeedSubcomponentProperty.InitialMessage should be going
Collaborator
Author
There was a problem hiding this comment.
Yes! I will add it in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Changes in the PR include:
MessageFeedinto a compound componentMessageFeed🎟 Jira ticket: LG-5934
🎟 Jira ticket: LG-5934
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes