CSHARP-5836: Support new Reverse with array overload introduced by .NET 10 #1848
Conversation
| // static constructor | ||
| static EnumerableMethod() | ||
| { | ||
| #if NET10_OR_GREATER |
There was a problem hiding this comment.
This #if def does not make any sense to me. We do not have any target defining it, so the code is never going to be executed.
There was a problem hiding this comment.
It makes sense if you consider that very soon we will be adding net10 as a target.
There was a problem hiding this comment.
Probably, but for now it's a dead-code. Why do we need to add this code to repo NOW?
There was a problem hiding this comment.
I've came across this question in CSHARP-5665 wanting to use CommonPrefixLength. I decided not to have a dead and untested code, and will note it as a future improvement for net10 target. I suggest doing the same here.
Also we don't have an official date to support net10 yet.
| return __where.MakeGenericMethod(tsource); | ||
| } | ||
|
|
||
| #if !NET10_OR_GREATER |
There was a problem hiding this comment.
Same here, this code will be always included, as we have no configuration to have NET10_OR_GREATER defined.
BorisDog
left a comment
BorisDog
left a comment
There was a problem hiding this comment.
Removed myself as a reviewer.
4 participants
No description provided.