CSHARP-5606: Support ConvertChecked as well as Convert #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelinowona
reviewed
Jan 20, 2026
Contributor
There was a problem hiding this comment.
This PR addresses the issue in aggregation expression translators only. However, filter translators may have the same problem. We should add test coverage for filters to determine whether they also require updates.
Also, in ConvertHelper.cs:
Several helper methods check NodeType == ExpressionType.Convert:
RemoveConvertToEnumUnderlyingType
RemoveConvertToInterface
RemoveConvertToObject
RemoveWideningConvert
These might also need updating (a check on ExpressionType.Convert) depending on their usage contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.