feat: implement the defineNetwork API
#2650
Draft
+1,958
−1,497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
force-pushed
the
fix/define-network
branch
from
720e665 to
f65e91d
Compare
kettanaito
changed the title
defineNetwork APIdefineNetwork API
kettanaito
force-pushed
the
fix/define-network
branch
from
1298da4 to
336a1bb
Compare
kettanaito
force-pushed
the
fix/define-network
branch
from
336a1bb to
7e2bf32
Compare
kettanaito
changed the title
defineNetwork APIdefineNetwork API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setupRemoteServer#1617Roadmap
handlersand the constructor argument for the handlers controller seems odd. Choose just one?handlersoption. After all,handlersare only needed as the input to the controller.setupServer. ThedefineNetworkAPI is rather low-level. ExportNetowrkOptionsto the user can just override some of them?