Popups open fix. New attempt #31852
Merged
Popups open fix. New attempt #31852
+14
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Jan 21, 2026
anchorGeometry uses data that is not available at this stage, such as the view geometry
they were opening on the primary screen because m_globalPos for the dialog had not yet been initialized
Contributor
Contributor
|
@cbjeukendrup Do you want to do CR after last changes? |
4 tasks
Member
|
Still looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #31821
Resolves: audacity/audacity#9990
Reverted #31077
Partially reverted #31606
Partially reverted #31134
(Main fix) New solution for #29556
What to check: