Skip to content

Conversation

@abhinavohri
Copy link
Contributor

Resolves: #7816
Summary:
This PR aims to show attachment list in the simple editor in viewing mode.

Before:
image

After:
image

@abhinavohri
Copy link
Contributor Author

Should attachments be visible during editing in simple editor, or hidden completely as they are now?
image

@SebastianKrupinski
Copy link
Contributor

Hi @abhinavohri

Thank you for the PR. But this change will need approval from the design team.

@SebastianKrupinski
Copy link
Contributor

@nimishavijay

What are your thoughts on this change?

My only comment would be maybe we should make the attachments section collapsible? or list them horizontally instead of vertically to save space.

@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews design: review 🔍 Bugs and features identified in design review calls labels Jan 2, 2026
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@GVodyanov
Copy link
Contributor

Hey! Might also ping @kra-mo, any ideas?

@kra-mo
Copy link
Member

kra-mo commented Jan 22, 2026

I think as far as space concerns go, it might make sense to only show the name and icon if there is a single attachment (or maybe two/three), and without a heading. If there are more, it could just say {n} attachments and show the paperclip :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design: review 🔍 Bugs and features identified in design review calls feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add attachment (with link) to calendar card

4 participants