-
Notifications
You must be signed in to change notification settings - Fork 285
feat: show attachments only in view mode for simple editor #7819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @abhinavohri Thank you for the PR. But this change will need approval from the design team. |
|
What are your thoughts on this change? My only comment would be maybe we should make the attachments section collapsible? or list them horizontally instead of vertically to save space. |
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hey! Might also ping @kra-mo, any ideas? |
|
I think as far as space concerns go, it might make sense to only show the name and icon if there is a single attachment (or maybe two/three), and without a heading. If there are more, it could just say |

Resolves: #7816
Summary:
This PR aims to show attachment list in the simple editor in viewing mode.
Before:

After:
