Fix: Not possible to close Event when Calendar is embedded into Collective #7848
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctive Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
Hi @Koc Thank you for the PR! Can you also update the description of the event with GH ticket this resolves. Thank you |
Koc
commented
Jan 12, 2026
Comment on lines
-407
to
+408
| this.calendarsStore.closeWidgetEventDetails() | ||
| this.widgetStore.closeWidgetEventDetails() |
Contributor
Author
There was a problem hiding this comment.
Is it possible somehow to detect such errors on compile/lint step?
Contributor
There was a problem hiding this comment.
I think @hamza221 worked on this and should maybe know
Contributor
Author
|
@SebastianKrupinski I can't find a ticket for that issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.