allow sharee to copy public link of a shared calendar #7888
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammaratef45
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
Signed-off-by: Ammar Hussein <ammaratef45@proton.me>
Contributor
|
HI @ammaratef45 Thank you for the PR. This change will need to get approved by product design. Also, the text in the menu needs to be aligned properly and should have an icon in front of it. |
Contributor
Member
Right, also no "PublicLink" heading. But the feature makes sense. |
Author
|
Thanks @SebastianKrupinski and @kra-mo I've updated the PR, here is how it looks now 
|
Signed-off-by: Ammar Hussein <ammaratef45@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot for before:
Screenshot for after: